Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect getModel NPE error #3170

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Protect getModel NPE error #3170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...in/java/software/uncharted/terarium/hmiserver/controller/dataservice/ModelController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,11 @@ ResponseEntity<Model> getModel(@PathVariable("id") final UUID id) {
// Append the Document extractions to the Model extractions, just for the
// front-end.
// Those are NOT to be saved back to the data-service.
model.get().getMetadata().getAttributes().addAll(extractions);
if (extractions != null) {
model.get().getMetadata().getAttributes().addAll(extractions);
} else {
log.error("No attributes added to Model as DocumentAsset ({}) has no attributes.", documentId);
}
YohannParis marked this conversation as resolved.
Show resolved Hide resolved
}
} catch (final Exception e) {
log.error("Unable to get the document " + documentId, e);
Expand Down
Loading