fix[hmi-server]: Improved Funman Errors #3238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catching exceptions thrown by the proxy service for funman operations. Also small code cleanup in eval controller.
YohannParis
approved these changes
Apr 2, 2024
|
@dvince2 funman-service has always been a bit quiet in terms of errors - what sort of reporting can we see now that we couldn't view before? |
|
Without this, any exceptions would have thrown a generic exception from the controller without a message and with a 500 error code. This will now properly bubble up the correct error code returned to us from the funman service and display a nicer error to the user. I've just been going through all of our controllers which make use of feignclient proxies to add this for better visibility on the front end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catching exceptions thrown by the proxy service for funman operations. Also small code cleanup in eval controller.