Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add string matching for automapping in calibration #3264

Merged
merged 8 commits into from
Apr 4, 2024
Merged

feat: add string matching for automapping in calibration #3264

merged 8 commits into from
Apr 4, 2024

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Apr 4, 2024 •
edited
Loading

Description

  • source and target are auto mapped by id; using the startsWith() function does it pretty well
  • I put a placeholder message "Please wait..." so the user knows that the variable options in the dropdowns are loading
Screen.Recording.2024-04-04.at.12.43.42.PM.mov

@shawnyama shawnyama marked this pull request as draft April 4, 2024 16:33
@shawnyama shawnyama linked an issue Apr 4, 2024 that may be closed by this pull request
automapping also covers string match #3222
Closed
@shawnyama shawnyama requested a review from Tom-Szendrey April 4, 2024 16:50
@shawnyama shawnyama marked this pull request as ready for review April 4, 2024 16:50
@shawnyama shawnyama requested a review from Tom-Szendrey April 4, 2024 18:08
Tom-Szendrey
Tom-Szendrey approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@Tom-Szendrey Tom-Szendrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@shawnyama shawnyama merged commit 099f036 into main Apr 4, 2024
5 checks passed
@shawnyama shawnyama deleted the automap-string-match branch April 4, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tom-Szendrey Tom-Szendrey Tom-Szendrey approved these changes

@YohannParis YohannParis Awaiting requested review from YohannParis YohannParis is a code owner

@mwdchang mwdchang Awaiting requested review from mwdchang mwdchang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

automapping also covers string match
2 participants
@shawnyama @Tom-Szendrey