feat[hmi-client]: The Documents / Models / Dataset switcher on the E… #3323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xplorer page ought to show number of items in each This is a bit of a 'first pass' at this task because of the horribly disjointed state the explorer is in. Some of the searches (models and xdd documents) happen all at once so we can populate them. Others (datasets) happen on demand. We also have two types of documents which makes this muddy (and in code there's only one type and then seperate checks??). As a result you won't get 100% accurate results in some of the cases until you click on the tabs which isn't great but its the best that can be done without doing the "big task" of addressing this data explorer...
…her-on-the-explorer-page-ought-to-show-number-of-items-in-each
mwdchang
reviewed
Apr 16, 2024
packages/client/hmi-client/src/page/data-explorer/DataExplorer.vue
Outdated
Show resolved
Hide resolved
mwdchang
reviewed
Apr 16, 2024
packages/client/hmi-client/src/page/data-explorer/DataExplorer.vue
Outdated
Show resolved
Hide resolved
…plorer page ought to show number of items in each PR Feedback - don't need to be template literals
…plorer page ought to show number of items in each PR Feedback - not refs
…her-on-the-explorer-page-ought-to-show-number-of-items-in-each
mwdchang
approved these changes
Apr 16, 2024
mwdchang
deleted the
1257-feat-the-documents-models-dataset-switcher-on-the-explorer-page-ought-to-show-number-of-items-in-each
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a bit of a 'first pass' at this task because of the horribly disjointed state the explorer is in. Some of the searches (models and xdd documents) happen all at once so we can populate them. Others (datasets) happen on demand. We also have two types of documents which makes this muddy (and in code there's only one type and then seperate checks??). As a result you won't get 100% accurate results in some of the cases until you click on the tabs which isn't great but its the best that can be done without doing the "big task" of addressing this data explorer...
Resolves #1257