Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix infinite succes on extractions #3335

Merged
merged 3 commits into from
Apr 16, 2024
Merged

fix infinite succes on extractions #3335

merged 3 commits into from
Apr 16, 2024

Conversation

blanchco
Copy link
Contributor

Description

  • fixed issue where we would get infinite green success panels of extraction from document
  • atob for base64 decoding rather than Textdecoder
  • close connection on error

@blanchco blanchco self-assigned this Apr 16, 2024
@blanchco blanchco linked an issue Apr 16, 2024 that may be closed by this pull request
Infinite loop when doing extraction from paper #3336
Closed
@blanchco blanchco merged commit 73a0ced into main Apr 16, 2024
5 checks passed
@blanchco blanchco deleted the fix-infinite-success-on-extractions branch April 16, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwdchang mwdchang mwdchang left review comments

@YohannParis YohannParis YohannParis approved these changes

Assignees

@blanchco blanchco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Infinite loop when doing extraction from paper
3 participants
@blanchco @YohannParis @mwdchang