Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split image building #3369

Merged
merged 81 commits into from
Apr 24, 2024
Merged

Split image building #3369

merged 81 commits into from
Apr 24, 2024

Conversation

YohannParis
Copy link
Member

@YohannParis YohannParis commented Apr 17, 2024 •
edited
Loading

Description

  • Split all the images built with their own workflow
  • Leverage macos to build arm version not possible until M2 available
  • Remove the main publish file

All the images built, I deleted most of them, but kept the taskrunner until this is merged:

@YohannParis
Update test-server.yaml
efe7e21
@YohannParis
Update publish.yaml
3e27b35
@YohannParis
Update ClientEvent.java
7409f58
@YohannParis
Update publish.yaml
fb3fe12
@YohannParis
Update ClientEvent.java
83c34a3
@YohannParis
Create publish-client.yml
ca8232d
@YohannParis
Merge branch 'main' into use-mac-os-to-build-arm-images
6735c59
@YohannParis
let's go with arm64
85ba5cb
@YohannParis
Update publish-client.yml
8ab1d0b
@YohannParis
add colima to run docker
436702f
@YohannParis
Update publish-client.yml
834d46d
@YohannParis
Update publish-client.yml
6b3b59c
@YohannParis
Update publish-client.yml
6304831
@YohannParis
Update publish-client.yml
177103e
@YohannParis
Install docker buildx
960e1bd
@YohannParis
start docker deamon
830951b
@YohannParis
Try to install and login with Podman
1876feb
@YohannParis
No dice.
522b3a6
@YohannParis
Try to start Colima within ressources
c321f41
@YohannParis
Final proper macos arm step
61ebf5d
@YohannParis
bring back amd64 and add arm64 emulation
c7e45d4
@YohannParis
Merge branch 'main' into use-mac-os-to-build-arm-images
c5073bf
@YohannParis
tidying up and fixing issue with node cache yarn
8843008
@YohannParis
tidying up
7bbbded
@YohannParis
Re-order and check if the image name is correct.
d636c58
@YohannParis
Update publish-client.yml
51f972c
@YohannParis
Update publish-client.yml
9fcce93
@YohannParis
rename env to DOCKERFILE_CONTEXT
86a655b
@YohannParis
fix some linting issues
bb7f4fa
@YohannParis
add manifest building
c003e97
@YohannParis YohannParis marked this pull request as ready for review April 22, 2024 19:22
dgauldie
dgauldie approved these changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@dgauldie dgauldie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@dgauldie dgauldie merged commit d71a577 into main Apr 24, 2024
5 checks passed
@dgauldie dgauldie deleted the use-mac-os-to-build-arm-images branch April 24, 2024 14:41
@YohannParis YohannParis mentioned this pull request Apr 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nithos Nithos Nithos left review comments

@dgauldie dgauldie dgauldie approved these changes

@mwdchang mwdchang Awaiting requested review from mwdchang mwdchang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YohannParis @Nithos @dgauldie