Taskrunner intermediate progress #3376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbirk
requested review from
YohannParis,
j2whiting,
dgauldie and
mwdchang
as code owners
mwdchang
approved these changes
Apr 19, 2024
YohannParis
reviewed
Apr 19, 2024
| final Process progressPipe = new ProcessBuilder("mkfifo", progressPipeName).start(); | ||
| exitCode = progressPipe.waitFor(); | ||
| if (exitCode != 0) { | ||
| throw new RuntimeException("Error creating input pipe"); |
There was a problem hiding this comment.
Should be Error creating progress pipe here.
Comment on lines
+268
to
+270
| } catch (final Exception e) { | ||
| // do nothing | ||
| } |
There was a problem hiding this comment.
Why doing a catch if we do nothing? To not stop the thread?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new progress pipe to be written to and forwards the output from the process, to the taskrunner, to the hmi-server