Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refresh document on extractions complete #3401

Merged
merged 9 commits into from
Apr 24, 2024
Merged

refresh document on extractions complete #3401

merged 9 commits into from
Apr 24, 2024

Conversation

blanchco
Copy link
Contributor

@blanchco blanchco commented Apr 22, 2024 •
edited
Loading

Description

  • Address an issue where the document asset would not refresh when extractions are finished.
  • Adding subscription of the extraction event in the document asset component so that we know when its done...there does seem to be some issues to know when extractions are fully completed (using time t), but will wait to add those changes in a PR after the notification system is integrated more

Resolves #(issue)

@blanchco blanchco self-assigned this Apr 22, 2024
@blanchco blanchco linked an issue Apr 22, 2024 that may be closed by this pull request
Auto-refresh assets after running extractions #3402
Closed
@blanchco blanchco marked this pull request as ready for review April 22, 2024 20:49
@blanchco blanchco requested review from jryu01, YohannParis and mwdchang and removed request for YohannParis and mwdchang April 22, 2024 20:49
@blanchco @YohannParis
Update packages/client/hmi-client/src/components/documents/tera-docum…
10e0a75 
…ent-asset.vue

Co-authored-by: Yohann Paris <github@yohannparis.com>
@blanchco
Copy link
Contributor Author

Waiting on #3412 to be merged to finish this up

@blanchco blanchco merged commit f7cef87 into main Apr 24, 2024
5 checks passed
@blanchco blanchco deleted the refresh-doc-on-extraction-complete branch April 24, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jryu01 jryu01 jryu01 left review comments

@YohannParis YohannParis YohannParis approved these changes

@mwdchang mwdchang Awaiting requested review from mwdchang mwdchang is a code owner

Assignees

@blanchco blanchco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto-refresh assets after running extractions
3 participants
@blanchco @YohannParis @jryu01