Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: funman taskrunner api plumbing #3411

Merged
merged 15 commits into from
Apr 24, 2024
Merged

Conversation

mwdchang
Copy link
Member

@mwdchang mwdchang commented Apr 23, 2024

Summary

This PR sets up running funman-taskrunner locally, as well as the intial plumbings to invoke model configuration validation task. This provides the means to run the task through a REST-API, inject the request with necessarily information for the next step/PR, and acknowledge a success/failure of the validation task.

The next steps/PR are to:

  • Hook into the Simulation way of doing things, create a simulation when task starts
  • Save result into S3, and update Simulation object with S3 URL
  • Rename/clean up

Testing

With curl or Postman, where funman-simple.json is attached:

funman-simple.json

curl \
  -v ${DEBUG:-} \
  -H "${AUTHORIZATION_HEADER}" \
  -H "Content-type: application/json" \
  -XPOST http://localhost:3000/funman/queries/test -d@funman-simple.json

@mwdchang mwdchang marked this pull request as ready for review April 23, 2024 20:14
@mwdchang mwdchang requested review from kbirk and removed request for dgauldie April 23, 2024 20:14
@mwdchang mwdchang merged commit 818aa5f into main Apr 24, 2024
9 checks passed
@mwdchang mwdchang deleted the funman-taskrunner-api-plumbing branch April 24, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants