fix: make sure id isn't present when saving as a new model
#3436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawnyama
changed the title
id isn't present when creating a new model
shawnyama
changed the title
id isn't present when creating a new modelid isn't present when saving as a new model
|
Let me know if it would be more appropriate to get rid of the |
YohannParis
reviewed
Apr 25, 2024
packages/client/hmi-client/src/components/workflow/ops/stratify-mira/tera-stratify-mira.vue
Outdated
Show resolved
Hide resolved
YohannParis
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Models with ids are being passed when creating a new model from the stratify drilldown and even the model edit if you try twice. I made sure to delete the
idproperty before the model is created. I also made some slight clean ups