harden(model-edit): save decomposed port positions for flattened view edits #3453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawnyama
changed the title
mwdchang
reviewed
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When port positions from the decomposed view aren't rendered (when we are in the flattened view) they must be saved so that the edges in the decomposed view are drawn properly as we reflect a flattened edit. This occurs specifically when we are creating a new junction. In the BEFORE video I am creating a junction for
R. If I did this withIthere wouldn't be a problem.BEFORE:
Screen.Recording.2024-04-26.at.1.05.12.PM.mov
AFTER:
Screen.Recording.2024-04-26.at.1.04.24.PM.mov