Ts/3398 interventions #3461
Merged
Ts/3398 interventions #3461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…S/3398-interventions
…M/TERArium into TS/3398-interventions
…S/3398-interventions
…M/TERArium into TS/3398-interventions
Tom-Szendrey
requested review from
dgauldie,
dvince2,
YohannParis and
mwdchang
as code owners
Tom-Szendrey
commented
Apr 30, 2024
.../java/software/uncharted/terarium/hmiserver/models/dataservice/modelparts/ModelMetadata.java
Show resolved
Hide resolved
mwdchang
reviewed
May 1, 2024
...e/uncharted/terarium/hmiserver/controller/simulationservice/SimulationRequestController.java
Show resolved
Hide resolved
mwdchang
reviewed
May 1, 2024
packages/client/hmi-client/src/components/workflow/ops/model-config/tera-model-config.vue
Show resolved
Hide resolved
mwdchang
reviewed
May 1, 2024
packages/client/hmi-client/src/components/model/petrinet/tera-model-intervention.vue
Outdated
Show resolved
Hide resolved
mwdchang
reviewed
May 1, 2024
...e/uncharted/terarium/hmiserver/controller/simulationservice/SimulationRequestController.java
Show resolved
Hide resolved
|
As the next step, we need to think about validations, so we don't end up with negative time steps or something like duplicated timesteps. |
dvince2
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Interventions to come from an intervention object within the model config rather than a weird timeseries string
Interventions for simulating to come from the payload provided as well as whatever is within the config provided
-Can run optimization + calibration + simulation with and without interventions.
-Can see both interventions from optimization as well as the configuration within the optimization's simulation
-Can add, delete, and update the interventions in the model config
Testing:
All the points above reran many times with pyciemss-api logs on the other screen
One.Of.Many.tests.mov