task[hmi-server] - server cleanup #3464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Did some legwork for future database work, bringing `description` and `name` into the parent `TerariumAsset` class, and updating all the tests for that. * Changing the data type of `description` to be text for future proofing. * Explicitly define string length on the two classes we've migrated so far * Wrote needed migrations.
dvince2
requested review from
dgauldie,
YohannParis and
mwdchang
as code owners
* I angered the javascript gods with that one
* fix server test
YohannParis
reviewed
Apr 29, 2024
packages/client/hmi-client/src/page/data-explorer/components/tera-search-results-list.vue
Show resolved
Hide resolved
packages/server/src/main/java/software/uncharted/terarium/hmiserver/models/TerariumAsset.java
Outdated
Show resolved
Hide resolved
...ain/java/software/uncharted/terarium/hmiserver/models/dataservice/simulation/Simulation.java
Show resolved
Hide resolved
* PR feedback changing to 512
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
descriptionandnameinto the parentTerariumAssetclass, and updating all the tests for that.descriptionto be text for future proofing.