Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stratified initials and parameter metadata on model page #3743

Merged
merged 68 commits into from
Jun 14, 2024

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented May 30, 2024

Description

  • Added base variables for initials and parameters that are stratified
  • You can toggle the base variables to view the stratified variables
  • As usual, base initials are edited in the model metadata - base parameters are not edited in the model.parameters as they don't exist there, for base parameters I am creating them in the metadata similarly to how initials are edited
  • Updated stratified matrix components to have a read only mode, the read only mode doesn't show values - just variables
  • You can open stratified matrices under base parameters to see how they relate to the initials (no need for initial matrices)
  • Got rid of an unused prop openValueConfig in tera-stratified-matrix-modal
Screen.Recording.2024-06-03.at.4.24.05.PM.mov

shawnyama added 30 commits May 28, 2024 14:04
@YohannParis
Copy link
Member

The elephant in the room, is that metadata is not a fully recognized field on the program. Before going too far down the rabbit hole of using a data structure that everyone else ignores, what are our plan and strategy to consolidate "metadata" after

* Model edit operations

* Model stratification operations

I don't think the outputs of these operations will have the original metadata intact.

This is the same problem we had with model configuration. We should not keep them as AMR and try to fix those issue with the rest of the program.
We need to think about a way for us to preserve metadata after a model edit or stratification for the UI. We have been talking for more than a year about this problem with TA2... and no one wants to solve it.
I propose that we create a model merging function to deal with those basic issues of receiving edited AMR that removes or destroy existing data.

@YohannParis YohannParis requested a review from mwdchang June 11, 2024 19:05
@shawnyama
Copy link
Contributor Author

Sorry, this PR looks huge now because I deleted the old tera-initial-table and tera-parameter-table and renamed the v2 components.

@shawnyama shawnyama merged commit 8a45c9b into main Jun 14, 2024
5 checks passed
@shawnyama shawnyama deleted the model-page-stratified-init-param-entries branch June 14, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK]: Model page stratified initial and parameter tables
4 participants