update client event service based on PanTera updates #3839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...s/server/src/main/java/software/uncharted/terarium/hmiserver/service/ClientEventService.java
Outdated
Show resolved
Hide resolved
...s/server/src/main/java/software/uncharted/terarium/hmiserver/service/ClientEventService.java
Outdated
Show resolved
Hide resolved
...s/server/src/main/java/software/uncharted/terarium/hmiserver/service/ClientEventService.java
Outdated
Show resolved
Hide resolved
...s/server/src/main/java/software/uncharted/terarium/hmiserver/service/ClientEventService.java
Outdated
Show resolved
Hide resolved
...s/server/src/main/java/software/uncharted/terarium/hmiserver/service/ClientEventService.java
Outdated
Show resolved
Hide resolved
bigglesandginger
approved these changes
Jun 13, 2024
|
This should be better, also I realise in my review I missed the anonymous functions inside the emitters which, if going with the locking approach, should also have been locking as access to a concurrent variable should be managed with locks. Though personally I dislike the Java 0.x synchronize method and prefer Java 1.6 Locks as they allow for differentation between read and write and more complicated senarios. Synchronize is a total hack of overloading every single object in Javaand should never have been allowed into the language... hurrumph. |
YohannParis
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #(issue)