Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: model edit initialization #3988

Merged
merged 11 commits into from
Jun 27, 2024
Merged

fix: model edit initialization #3988

merged 11 commits into from
Jun 27, 2024

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Jun 26, 2024 •
edited
Loading

Description

  • Model edit drilldown appears properly
  • Beaker timeout errors are avoided by not generating a summary for the output

image

@shawnyama shawnyama marked this pull request as ready for review June 26, 2024 19:52
@shawnyama shawnyama linked an issue Jun 26, 2024 that may be closed by this pull request
[BUG]: Model Edit - Cannot connect to Beaker while summary is still generating? #3932
Closed
Tom-Szendrey
Tom-Szendrey approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@Tom-Szendrey Tom-Szendrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine enough.

@shawnyama shawnyama merged commit def072a into main Jun 27, 2024
5 checks passed
@shawnyama shawnyama deleted the model-edit-init-fix branch June 27, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tom-Szendrey Tom-Szendrey Tom-Szendrey approved these changes

@mwdchang mwdchang mwdchang approved these changes

@YohannParis YohannParis Awaiting requested review from YohannParis YohannParis is a code owner

@blanchco blanchco Awaiting requested review from blanchco blanchco is a code owner

@asylves1 asylves1 Awaiting requested review from asylves1 asylves1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Model Edit - Cannot connect to Beaker while summary is still generating?
3 participants
@shawnyama @mwdchang @Tom-Szendrey