Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: shutdown jupyter session on page unload #4006

Merged
merged 5 commits into from
Jun 28, 2024
Merged

fix: shutdown jupyter session on page unload #4006

merged 5 commits into from
Jun 28, 2024

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Jun 27, 2024 •
edited
Loading

Description

  • Avoids hanging jupyter sessions
  • If the user unloads the page the session still exists, now it is shutdown
  • The way we've been shutting down the session is limited to the component level - eg. in tera-model-edit the onUnmounted(() => kernelManager.shutdown) only triggers if you close the drilldown
Screen.Recording.2024-06-27.at.3.31.15.PM.mov

@shawnyama shawnyama marked this pull request as ready for review June 27, 2024 19:25
@shawnyama shawnyama changed the title fix: shutdown jupyter session on page refresh fix: shutdown jupyter session on page unload Jun 27, 2024
@shawnyama shawnyama merged commit b587bb4 into main Jun 28, 2024
5 checks passed
@shawnyama shawnyama deleted the no-hanging-jupyter-session branch June 28, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blanchco blanchco blanchco approved these changes

@mwdchang mwdchang mwdchang approved these changes

@YohannParis YohannParis Awaiting requested review from YohannParis YohannParis is a code owner

@Tom-Szendrey Tom-Szendrey Awaiting requested review from Tom-Szendrey Tom-Szendrey is a code owner

@mattprintz mattprintz Awaiting requested review from mattprintz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shawnyama @mwdchang @blanchco