Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to gradle 8 #4167

Merged
merged 7 commits into from
Aug 1, 2024
Merged

Update to gradle 8 #4167

merged 7 commits into from
Aug 1, 2024

Conversation

bigglesandginger
Copy link
Contributor

Description

  • Include a summary of the changes and the related issue.
  • Include relevant motivation and context.

Resolves #(issue)

YohannParis
YohannParis approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my local

@dvince2 dvince2 mentioned this pull request Jul 17, 2024
Merged
@dvince2
Copy link
Collaborator

dvince2 commented Jul 17, 2024

@chris-dickson what was the issue pantera had with java 21? Was it the java formatter?

@chris-dickson
Copy link
Contributor

@chris-dickson what was the issue pantera had with java 21? Was it the java formatter?

Yes. It doesn't work well on the new Java 21 features.

@YohannParis YohannParis requested a review from kbirk as a code owner July 17, 2024 19:55
@YohannParis
Copy link
Member

YohannParis commented Jul 17, 2024 •
edited
Loading

@chris-dickson what was the issue pantera had with java 21? Was it the java formatter?

Yes. It doesn't work well on the new Java 21 features.

Works on us.

Screenshot 2024-07-17 at 15 58 43

dvince2
dvince2 approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@dvince2 dvince2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but lets not merge until after the demo has happened?

@dgauldie dgauldie merged commit 956bc0f into main Aug 1, 2024
6 checks passed
@dgauldie dgauldie deleted the update_to_gradle_8 branch August 1, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvince2 dvince2 dvince2 approved these changes

@YohannParis YohannParis YohannParis approved these changes

@dgauldie dgauldie Awaiting requested review from dgauldie dgauldie is a code owner

@mwdchang mwdchang Awaiting requested review from mwdchang mwdchang is a code owner

@kbirk kbirk Awaiting requested review from kbirk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bigglesandginger @dvince2 @chris-dickson @YohannParis @dgauldie