Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: string expression to latex expression conversion #4181

Merged
merged 13 commits into from
Jul 23, 2024
Merged

feat: string expression to latex expression conversion #4181

merged 13 commits into from
Jul 23, 2024

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Jul 18, 2024 •
edited
Loading

Description

  • String expressions can now be converted to latex so they can be rendered nicely in <katex-element>
  • Did some back and forth with copilot until I got something I liked
  • Before:
    image
  • After:
    image

YohannParis
YohannParis approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@shawnyama shawnyama requested a review from jryu01 July 18, 2024 20:13
@shawnyama shawnyama marked this pull request as draft July 19, 2024 22:48
@shawnyama shawnyama marked this pull request as ready for review July 23, 2024 16:57
@shawnyama shawnyama requested a review from mwdchang July 23, 2024 16:57
@shawnyama shawnyama merged commit cd820e7 into main Jul 23, 2024
5 checks passed
@shawnyama shawnyama deleted the fix-trans-expr branch July 23, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwdchang mwdchang mwdchang approved these changes

@YohannParis YohannParis YohannParis approved these changes

@Tom-Szendrey Tom-Szendrey Awaiting requested review from Tom-Szendrey Tom-Szendrey is a code owner

@blanchco blanchco Awaiting requested review from blanchco blanchco is a code owner

@jryu01 jryu01 Awaiting requested review from jryu01 jryu01 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shawnyama @YohannParis @mwdchang