Calibration, support before and after simulations for comparisions #4197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YohannParis
reviewed
Jul 19, 2024
...lient/hmi-client/src/components/workflow/ops/calibrate-ciemss/tera-calibrate-node-ciemss.vue
Show resolved
Hide resolved
YohannParis
approved these changes
Jul 19, 2024
| @@ -9,10 +9,12 @@ export interface CalibrationOperationStateCiemss extends BaseState { | |||
| simulationsInProgress: string[]; | |||
|
|
|||
| inProgressCalibrationId: string; | |||
| inProgressBeforeForecastId: string; | |||
There was a problem hiding this comment.
I used slightly different wording for optimize version of this
inProgressPostForecastId
Do we care to sync these? Do we care which we sync with?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add in plumbings to support doing a "before" simulate with what is in model-configuration, and an "after" simulate with altered parameters from calibrate.
Testing
No UI changes for now, calibrate should work as before, but before/after simulationIds will be recorded.