Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(calibrate): don't hide add charts button if there's no charts #4221

Merged
merged 1 commit into from
Jul 23, 2024
Merged

fix(calibrate): don't hide add charts button if there's no charts #4221

merged 1 commit into from
Jul 23, 2024

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Jul 22, 2024 •
edited
Loading

Description

  • Just found this problem in the calibrate drilldown
  • Checked for it in simulate but didn't find, just did some cleanups

image

@shawnyama shawnyama linked an issue Jul 22, 2024 that may be closed by this pull request
[BUG]: When all charts are delete of the preview panel, you cannot add more #4202
Closed
@shawnyama shawnyama requested a review from Tom-Szendrey July 22, 2024 23:19
@shawnyama shawnyama changed the title fix(calibrate): dont hide section if theres no charts fix(calibrate): don't hide add charts button if there's no charts Jul 22, 2024
@shawnyama shawnyama requested a review from blanchco July 22, 2024 23:26
@shawnyama shawnyama merged commit 3d3d50f into main Jul 23, 2024
5 checks passed
@shawnyama shawnyama deleted the add-chart-fix branch July 23, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwdchang mwdchang mwdchang approved these changes

@YohannParis YohannParis YohannParis approved these changes

@Tom-Szendrey Tom-Szendrey Awaiting requested review from Tom-Szendrey Tom-Szendrey is a code owner

@blanchco blanchco Awaiting requested review from blanchco blanchco is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: When all charts are delete of the preview panel, you cannot add more
3 participants
@shawnyama @YohannParis @mwdchang