Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PG indexes #4230

Merged
merged 4 commits into from
Jul 23, 2024
Merged

Add PG indexes #4230

merged 4 commits into from
Jul 23, 2024

Conversation

kbirk
Copy link
Contributor

@kbirk kbirk commented Jul 23, 2024

Unfortunately there isn't support in hibernate for partial indixes. Ideally we would index on IS NULL for deletedOn to speed those up.

We can put those in flyway, but due to how we setup the baselineVersion stuff, it would skip those.

@kbirk kbirk requested a review from bigglesandginger July 23, 2024 15:25
YohannParis
YohannParis approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwdchang mwdchang changed the title Add some indexes Add PG indexes Jul 23, 2024
@kbirk kbirk merged commit 815e539 into main Jul 23, 2024
6 checks passed
@kbirk kbirk deleted the kbirk/indexes-and-fixes branch July 23, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgauldie dgauldie dgauldie approved these changes

@YohannParis YohannParis YohannParis approved these changes

@dvince2 dvince2 Awaiting requested review from dvince2 dvince2 is a code owner

@bigglesandginger bigglesandginger Awaiting requested review from bigglesandginger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kbirk @YohannParis @dgauldie