Fixing wrong model configuration selection #4247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After creating a new model configuration, we weren't properly selecting it from the the list of model configs. As a result the output and the download would be the last selected/created config even though it *looked* like it shouldn't be. In addition I've found more casting exceptions because of the presence of `Object` in the back end. This should be `Number` but that could break our python services down stream, and requires a migration and I just want to get it in. Lastly, we should return the new model we've created ;)
YohannParis
approved these changes
Jul 23, 2024
...s/client/hmi-client/src/components/workflow/ops/model-config/tera-model-config-drilldown.vue
Show resolved
Hide resolved
…onfig/tera-model-config-drilldown.vue lets make it weird Co-authored-by: Yohann Paris <github@yohannparis.com>
…/model-config/tera-model-config-drilldown.vue " This reverts commit 2045191.
shawnyama
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Objectin the back end. This should beNumberbut that could break our python services down stream, and requires a migration and I just want to get it in.Resolves #noissue