Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: clean up slider and carousel #4261

Merged
merged 11 commits into from
Jul 24, 2024
Merged

style: clean up slider and carousel #4261

merged 11 commits into from
Jul 24, 2024

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Jul 24, 2024

Description

  • I noticed an random chevron was placed in the slider (in the Data Explorer) and then I figured out it was from the carousel in a tera-asset-card
  • we are getting rid of carousels from the asset cards but in case the carousel is used anywhere else in the future this would be helpful
  • I am commenting out the chevrons for now since I am not coming across carousels int the data explorer anymore..., we'll worry about them once we use them again
  • I couldn't resist writing a more readable tera-slider

@shawnyama shawnyama requested review from blanchco and asylves1 July 24, 2024 18:08
@shawnyama shawnyama marked this pull request as ready for review July 24, 2024 18:17
@shawnyama shawnyama merged commit d7bf0df into main Jul 24, 2024
5 checks passed
@shawnyama shawnyama deleted the carousel-cleanup branch July 24, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants