Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calibrate model config #4266

Merged
merged 6 commits into from
Jul 25, 2024
Merged

Calibrate model config #4266

merged 6 commits into from
Jul 25, 2024

Conversation

mwdchang
Copy link
Member

Summary

Create model-config (pointing to the calibrated dill file) in calibrate, instead of a special calibrate-simulation-id

image

Testing

Run calibrate, and attach the output to simulation, run simulation and check simulation result to see that they fall within the expected range.

@mwdchang mwdchang requested a review from YohannParis as a code owner July 25, 2024 13:44
@mwdchang mwdchang requested review from Tom-Szendrey and jryu01 July 25, 2024 13:48
@Tom-Szendrey
Copy link
Contributor

Optimize drilldown shares the same inferred_parameters logic as simulate does.
If that is to be done in a follow up PR or you want to throw that my way no problem

Copy link
Contributor

@Tom-Szendrey Tom-Szendrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!

@mwdchang mwdchang merged commit 1e00dbf into main Jul 25, 2024
5 checks passed
@mwdchang mwdchang deleted the calibrate-model-config branch July 25, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants