update model-config for housing calibration result #4308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvince2
approved these changes
Jul 30, 2024
blanchco
approved these changes
Jul 30, 2024
YohannParis
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove
calibrationRunId, it is not used.Add in an optional
inferredParameterListto house sampling of calibrated result, which we have defined to be the "mean" and "standard deviation" of the samples taken.We could potentially stick these sampling metrics into
parameterSemanticList, but I think explicitly separating them is cleaner and also a lot easier - since we don't need to retroactively go back to places that use initialSemanticList and add additional readonly guards and whatnot, or discard them when we recreate AMR for external services, and finally just less error prone in general. But happy to discuss if there are other thoughts.Testing
No functional changes, things relating to model-configurations should work as before