Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

primevue number -> tera input number #4338

Merged
merged 15 commits into from
Aug 2, 2024
Merged

primevue number -> tera input number #4338

merged 15 commits into from
Aug 2, 2024

Conversation

blanchco
Copy link
Contributor

Description

@blanchco blanchco self-assigned this Jul 31, 2024
@blanchco blanchco linked an issue Jul 31, 2024 that may be closed by this pull request
We should see if we can replace Primevue's input with tera-input, so we don't have very similar components flying around. #4294
Closed
Base automatically changed from primevue-text-to-tera-text-p1 to main August 1, 2024 17:25
@blanchco blanchco marked this pull request as ready for review August 1, 2024 17:29
@blanchco blanchco requested a review from shawnyama August 1, 2024 17:29
@blanchco blanchco linked an issue Aug 1, 2024 that may be closed by this pull request
[TASK]: House cleaning #4033
Closed
5 tasks
YohannParis
YohannParis approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! As good as The Fall Guy

@blanchco blanchco merged commit d641945 into main Aug 2, 2024
5 checks passed
@blanchco blanchco deleted the primevue-number-to-tera-number branch August 2, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawnyama shawnyama shawnyama approved these changes

@YohannParis YohannParis YohannParis approved these changes

@mwdchang mwdchang Awaiting requested review from mwdchang mwdchang is a code owner

Assignees

@blanchco blanchco

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@blanchco @YohannParis @shawnyama