Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add + button back into asset card #4346

Merged
merged 3 commits into from
Aug 2, 2024
Merged

fix: add + button back into asset card #4346

merged 3 commits into from
Aug 2, 2024

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Aug 1, 2024 •
edited
Loading

Description

  • When testing compare models the add to project button was missing when I was searching for the models to compare
  • I know we are getting rid of search but this still will be helpful for a while
  • Also cleaned up some unused props

@shawnyama shawnyama marked this pull request as ready for review August 1, 2024 19:32
@shawnyama shawnyama requested review from asylves1 and blanchco August 1, 2024 21:20
@shawnyama shawnyama merged commit ec4ce16 into main Aug 2, 2024
5 checks passed
@shawnyama shawnyama deleted the fix-asset-card branch August 2, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwdchang mwdchang mwdchang approved these changes

@YohannParis YohannParis YohannParis approved these changes

@asylves1 asylves1 Awaiting requested review from asylves1 asylves1 is a code owner

@blanchco blanchco Awaiting requested review from blanchco blanchco is a code owner

@jryu01 jryu01 Awaiting requested review from jryu01 jryu01 is a code owner

@Tom-Szendrey Tom-Szendrey Awaiting requested review from Tom-Szendrey Tom-Szendrey is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shawnyama @YohannParis @mwdchang