Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add options for node menu #4354

Merged
merged 15 commits into from
Aug 6, 2024
Merged

Add options for node menu #4354

merged 15 commits into from
Aug 6, 2024

Conversation

asylves1
Copy link
Contributor

@asylves1 asylves1 commented Aug 2, 2024

Description

image

Resolves #(issue)

@asylves1 asylves1 marked this pull request as ready for review August 2, 2024 18:45
@asylves1 asylves1 requested a review from YohannParis as a code owner August 2, 2024 18:45
@asylves1 asylves1 requested review from shawnyama and blanchco August 2, 2024 19:47
@mwdchang
Copy link
Member

mwdchang commented Aug 2, 2024 •
edited
Loading

Need to unique the candidate items, eg there are two "compare models" in the menu items.

image

@asylves1
Copy link
Contributor Author

asylves1 commented Aug 2, 2024 •
edited
Loading

Need to unique the candidate items, eg there are two "compare models" in the menu items.

image

Pushed for menu bug
image

@mwdchang
Copy link
Member

mwdchang commented Aug 3, 2024

I took some liberties to clean up a few things

  • There were some redundant checks that were not necessary, the data structure calls for the fields to be present so the algorithm can be made simpler
  • Renamed a few things, namely input/output, key/value which are a little vague

@mwdchang mwdchang merged commit 25d4855 into main Aug 6, 2024
5 checks passed
@mwdchang mwdchang deleted the add-options-for-node-menu branch August 6, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwdchang mwdchang mwdchang approved these changes

@YohannParis YohannParis YohannParis approved these changes

@shawnyama shawnyama Awaiting requested review from shawnyama shawnyama is a code owner

@blanchco blanchco Awaiting requested review from blanchco blanchco is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asylves1 @mwdchang @YohannParis