Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor stratify related components , fix equations to model saving #4369

Merged
merged 8 commits into from
Aug 6, 2024

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Aug 6, 2024

Description

  • During my transition matrix investigation I did some cleanups/fixes
  • Fixed saving model in eqautions to model drilldown

@shawnyama shawnyama changed the title fix: refactor: stratify related components Aug 6, 2024
@shawnyama shawnyama changed the title refactor: stratify related components refactor stratify related components Aug 6, 2024
@shawnyama shawnyama marked this pull request as ready for review August 6, 2024 16:10
@shawnyama shawnyama requested a review from a team August 6, 2024 16:10
@shawnyama shawnyama changed the title refactor stratify related components refactor stratify related components and equations to model saving Aug 6, 2024
@shawnyama shawnyama changed the title refactor stratify related components and equations to model saving refactor stratify related components , fix equations to model saving Aug 6, 2024
Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwdchang mwdchang requested review from mwdchang and blanchco August 6, 2024 17:52
Copy link
Member

@mwdchang mwdchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shawnyama next time put the fix into a different PR, it makes things easier to track and revert if needed.

@shawnyama shawnyama merged commit 3c88179 into main Aug 6, 2024
5 checks passed
@shawnyama shawnyama deleted the parameter-matrix-fix branch August 6, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants