parameter with strata suffixes #4370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawnyama
previously approved these changes
Aug 6, 2024
YohannParis
approved these changes
Aug 7, 2024
packages/client/hmi-client/src/model-representation/mira/mira.ts
Outdated
Show resolved
Hide resolved
blanchco
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support for
param_renaming_uses_strata_namesparameter in MIRA stratify:Note there appears to be a problem in MIRA with stratify where it replicates template names, this can mess up the model because there may be multiple expressions applied to a single transition.
Testing
Stratify a model including parameters, eg. stratify SIR with ages=young,old applied to S and beta.
Verify that the new beta parameters have young/old suffixes instead of numbers