Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Calibrate Output Type #4424

Merged
merged 17 commits into from
Aug 13, 2024
Merged

Update Calibrate Output Type #4424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
8a869b3
rename simulate drilldown.
Tom-Szendrey Aug 12, 2024
4dfafb8
Need to correct race condition
Tom-Szendrey Aug 12, 2024
5a737c1
correction, append state - also include forecastId
Tom-Szendrey Aug 12, 2024
5b21c8c
Re-label
Tom-Szendrey Aug 12, 2024
c340d58
correction to comment
Tom-Szendrey Aug 12, 2024
e93644b
Step 1) change output type + value
Tom-Szendrey Aug 12, 2024
d0f9b7f
utilize existing endpoint + update it
Tom-Szendrey Aug 12, 2024
460d408
removing console.logs
Tom-Szendrey Aug 12, 2024
90021fc
correct save asset Id used
Tom-Szendrey Aug 12, 2024
e8b68bc
Merge branch 'TS/4376-update-workflow-outputs' of https://github.com/…
Tom-Szendrey Aug 12, 2024
bec6932
utilize correct endpoint
Tom-Szendrey Aug 12, 2024
9591a24
no more temporary, addToProject flag.
Tom-Szendrey Aug 12, 2024
9cb2cac
Merge branch 'TS/4376-update-workflow-outputs' of https://github.com/…
Tom-Szendrey Aug 12, 2024
0629bef
addToProject = false.
Tom-Szendrey Aug 12, 2024
0214cd6
Merge branch 'main' of https://github.com/DARPA-ASKEM/TERArium into T…
Tom-Szendrey Aug 12, 2024
6e7ece8
Good tip Yohann!
Tom-Szendrey Aug 13, 2024
e467de3
Being logged in createDatasetFromSimulationResult
Tom-Szendrey Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ges/client/hmi-client/src/components/workflow/ops/calibrate-ciemss/calibrate-operation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export const CalibrationOperationCiemss: Operation = {
isOptional: true
}
],
outputs: [{ type: 'modelConfigId' }],
outputs: [{ type: 'modelConfigId|datasetId' }],
isRunnable: true,

action: async () => {},
Expand Down
19 changes: 17 additions & 2 deletions ...nt/hmi-client/src/components/workflow/ops/calibrate-ciemss/tera-calibrate-node-ciemss.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,10 @@ import { createLLMSummary } from '@/services/summary-service';
import { createForecastChart } from '@/services/charts';
import VegaChart from '@/components/widgets/VegaChart.vue';
import * as stats from '@/utils/stats';
import { createDatasetFromSimulationResult } from '@/services/dataset';
import { useProjects } from '@/composables/project';
import type { CalibrationOperationStateCiemss } from './calibrate-operation';
import { CalibrationOperationCiemss } from './calibrate-operation';
import { renameFnGenerator, mergeResults } from './calibrate-utils';

const props = defineProps<{
Expand Down Expand Up @@ -396,13 +399,25 @@ watch(
initialSemanticList: _.cloneDeep(baseConfig.initialSemanticList),
inferredParameterList: inferredParameters
};

const modelConfigResponse = await createModelConfiguration(calibratedModelConfig);
const datasetName = `Forecast run ${state.forecastId}`;
const projectId = useProjects().activeProjectId.value;
const datasetResult = await createDatasetFromSimulationResult(projectId, state.forecastId, datasetName, false);
if (!datasetResult) {
return;
}

// const portLabel = props.node.inputs[0].label;
emit('append-output', {
type: 'modelConfigId',
type: CalibrationOperationCiemss.outputs[0].type,
label: nodeOutputLabel(props.node, `Calibration Result`),
value: [modelConfigResponse.id],
value: [
{
modelConfigId: modelConfigResponse.id,
datasetId: datasetResult.id
}
],
state: {
calibrationId: state.calibrationId,
forecastId: state.forecastId,
Expand Down
Loading