Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow wrapper class #4441

Merged
merged 21 commits into from
Aug 13, 2024
Merged

Workflow wrapper class #4441

merged 21 commits into from
Aug 13, 2024

Conversation

mwdchang
Copy link
Member

@mwdchang mwdchang commented Aug 13, 2024

Summary

Wrap workflow data structure inside WorkflowWrapper class to make accidental data corruption less likely. There are a lot of changes but basically they are of the form:

From

blah = workflowService.doSomething(wf, param1, param2, ...)

To

blah wf.doSomething(param1, param2)

If you use the WorkflowWrapper then generally speaking you don't need to deal with isDeleted and version flags.

@mwdchang mwdchang marked this pull request as ready for review August 13, 2024 17:00
Copy link
Collaborator

@dvince2 dvince2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handy!

Copy link
Contributor

@Tom-Szendrey Tom-Szendrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!!

@mwdchang mwdchang merged commit 08feee7 into main Aug 13, 2024
8 checks passed
@mwdchang mwdchang deleted the workflow-wrapper-class branch August 13, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants