Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fixes unit entry): specify characters you want to reject from tera-input #4463

Merged
merged 12 commits into from
Aug 15, 2024
Merged

feat(fixes unit entry): specify characters you want to reject from tera-input #4463

merged 12 commits into from
Aug 15, 2024

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Aug 14, 2024 •
edited
Loading

Description

  • Reject specific characters we don't want with charactersToReject prop in tera-input-text
  • This handles the rejection of spaces in the unit entry better
Screen.Recording.2024-08-14.at.3.06.48.PM.mov

@shawnyama shawnyama changed the title feat: specify characters you want to reject from tera-input (fixes unit entry) feat(fixes unit entry): specify characters you want to reject from tera-input (fixes unit entry) Aug 14, 2024
@shawnyama shawnyama changed the title feat(fixes unit entry): specify characters you want to reject from tera-input (fixes unit entry) feat(fixes unit entry): specify characters you want to reject from tera-input Aug 14, 2024
@shawnyama shawnyama linked an issue Aug 14, 2024 that may be closed by this pull request
[BUG]: amr_to_mmt doesn't work if a unit expression has a space #4174
Closed
@shawnyama shawnyama marked this pull request as ready for review August 14, 2024 19:08
@shawnyama shawnyama merged commit 744978c into main Aug 15, 2024
5 checks passed
@shawnyama shawnyama deleted the settle-unit-editing branch August 15, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwdchang mwdchang mwdchang approved these changes

@YohannParis YohannParis YohannParis approved these changes

@jryu01 jryu01 Awaiting requested review from jryu01 jryu01 is a code owner

@Tom-Szendrey Tom-Szendrey Awaiting requested review from Tom-Szendrey Tom-Szendrey is a code owner

@blanchco blanchco Awaiting requested review from blanchco blanchco is a code owner

@asylves1 asylves1 Awaiting requested review from asylves1 asylves1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: amr_to_mmt doesn't work if a unit expression has a space
3 participants
@shawnyama @YohannParis @mwdchang