Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix model edit reset in wizard #4474

Merged
merged 8 commits into from
Aug 19, 2024
Merged

Fix model edit reset in wizard #4474

merged 8 commits into from
Aug 19, 2024

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Aug 15, 2024 •
edited
Loading

Description

  • If reset is clicked in wizard view, rerender the decomposed canvas. This needs to be rerendered since changes in the decomposed view are typically done by user actions (after the initial flattenedToDecomposed conversion). It worked from the Notebook view since the onMounted was retriggered on tab change.
  • Removed unneeded class and prop passing
Screen.Recording.2024-08-15.at.6.38.09.PM.mov

@shawnyama shawnyama linked an issue Aug 15, 2024 that may be closed by this pull request
[BUG]: Clicking RESET in Wizard mode does not visually change #4396
Closed
@shawnyama shawnyama marked this pull request as ready for review August 16, 2024 13:42
mwdchang
mwdchang approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@mwdchang mwdchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test - code looks okay!

@shawnyama shawnyama merged commit 5a1c90a into main Aug 19, 2024
5 checks passed
@shawnyama shawnyama deleted the fix-model-edit-reset branch August 19, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwdchang mwdchang mwdchang approved these changes

@YohannParis YohannParis YohannParis approved these changes

@jryu01 jryu01 Awaiting requested review from jryu01 jryu01 is a code owner

@Tom-Szendrey Tom-Szendrey Awaiting requested review from Tom-Szendrey Tom-Szendrey is a code owner

@blanchco blanchco Awaiting requested review from blanchco blanchco is a code owner

@asylves1 asylves1 Awaiting requested review from asylves1 asylves1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Clicking RESET in Wizard mode does not visually change
3 participants
@shawnyama @YohannParis @mwdchang