Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

another attempt at fixing workflow bugs #4486

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Conversation

mwdchang
Copy link
Member

Summary

We cannot just do nodeA = Object.assign(nodeA, update) because some of our operators are written to be very reactive - in their watcher they do not check if the new/old values are equivalent. So when we sync up with the database it triggers, among other things, unwanted append-output cycles, which itself invalidates downstream and marks the workflow dirty in order to trigger another update ... and so the cycle repeats.

So instead we need to update node piecemeal

Copy link
Contributor

@Tom-Szendrey Tom-Szendrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first glance this makes sense and LGTM
Passes a quick round of monkey testing

@mwdchang mwdchang merged commit d0b3d77 into main Aug 16, 2024
5 checks passed
@mwdchang mwdchang deleted the more-client-update-fix branch August 16, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants