another attempt at fixing workflow bugs #4486
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We cannot just do
nodeA = Object.assign(nodeA, update)
because some of our operators are written to be very reactive - in their watcher they do not check if the new/old values are equivalent. So when we sync up with the database it triggers, among other things, unwanted append-output cycles, which itself invalidates downstream and marks the workflow dirty in order to trigger another update ... and so the cycle repeats.So instead we need to update node piecemeal