-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dvince/clean up workflows #4499
Conversation
…ned edges/nodes at startup
.../src/main/java/software/uncharted/terarium/hmiserver/repository/data/WorkflowRepository.java
Outdated
Show resolved
Hide resolved
.../src/main/java/software/uncharted/terarium/hmiserver/repository/data/WorkflowRepository.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a "best of both worlds" approach. It is clear, the SQL is easy to read, and the Java leverages the existing knowledge space. Could it be faster all in PostGres... maybe but for not much of a gain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't test, but code seems okay
Description
This is a tentitive proposal for how to clean up workflows. Functionally this works however I'm not sure if its the "best" solution available and any feedback would be welcome. Basically...
nodes
andedges
columns which are json arrays, and collect any workflows which have a node and an edge marked for deletionIs it possible to find both nodes and edges at once in a single call or will it always be two?