Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compare-models): add markdown renderer and prepare for overview save #4509

Merged
merged 15 commits into from
Aug 22, 2024
Merged

fix(compare-models): add markdown renderer and prepare for overview save #4509

merged 15 commits into from
Aug 22, 2024

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Aug 20, 2024 •
edited
Loading

Description

  • setup overview id in state so it can reference the saved overview in the backend
  • I grant the model compare a default status once the overview is generated
  • added markdown-it package to render markdown
Screen.Recording.2024-08-20.at.1.57.52.PM.mov

@shawnyama shawnyama linked an issue Aug 20, 2024 that may be closed by this pull request
[BUG]: Compare models - partial pass, partial fail #4469
Closed
@shawnyama shawnyama changed the title fix(compare-models): overview is saved in state fix(compare-models): overview is saved in state, add markdown renderer Aug 20, 2024
@shawnyama shawnyama marked this pull request as ready for review August 20, 2024 18:01
Tom-Szendrey
Tom-Szendrey approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@Tom-Szendrey Tom-Szendrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as first pass (Still not saving to state as you mentioned)

@shawnyama shawnyama merged commit dec5ee2 into main Aug 22, 2024
5 checks passed
@shawnyama shawnyama deleted the fix-compare-models branch August 22, 2024 00:06
@shawnyama shawnyama changed the title fix(compare-models): overview is saved in state, add markdown renderer fix(compare-models): add markdown renderer and prepare for overview save Aug 22, 2024
@mwdchang mwdchang mentioned this pull request Sep 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tom-Szendrey Tom-Szendrey Tom-Szendrey approved these changes

@mwdchang mwdchang mwdchang approved these changes

@jryu01 jryu01 Awaiting requested review from jryu01 jryu01 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Compare models - partial pass, partial fail
3 participants
@shawnyama @mwdchang @Tom-Szendrey