Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken missing indices in tests and disable problematic async stuff in tests #4516

Merged
merged 5 commits into from
Aug 22, 2024

Conversation

kbirk
Copy link
Contributor

@kbirk kbirk commented Aug 20, 2024

No description provided.

@kbirk kbirk changed the title Fix broken missing indices and async stuff Fix broken missing indices in tests and disable problemmatic async stuff in tests Aug 21, 2024
@kbirk kbirk requested a review from bigglesandginger August 22, 2024 14:06
@kbirk kbirk changed the title Fix broken missing indices in tests and disable problemmatic async stuff in tests Fix broken missing indices in tests and disable problematic async stuff in tests Aug 22, 2024
Copy link
Contributor

@bigglesandginger bigglesandginger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sure there is some proper "mock" way to do this, but I understand this :)

@kbirk kbirk merged commit e37f133 into main Aug 22, 2024
6 checks passed
@kbirk kbirk deleted the kbirk/fix-broken-tests branch August 22, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants