Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4452 Added expand feature for the vega chart #4518

Merged
merged 9 commits into from
Aug 21, 2024
Merged

4452 Added expand feature for the vega chart #4518

merged 9 commits into from
Aug 21, 2024

Conversation

jryu01
Copy link
Contributor

@jryu01 jryu01 commented Aug 20, 2024

Description

  • Allow vega chart to be expanded and rendered in a larger modal once expand button is clicked.
  • Added expand prop to the vegachart to show the expand button on the chart.
  • When a function is provided to expand, function returns the customized chart spec to be rendered in the expand mode.
expand-chart.mov

Resolves #4452

Copy link
Member

@mwdchang mwdchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Copy link
Contributor

@Tom-Szendrey Tom-Szendrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@jryu01 jryu01 merged commit d3997e8 into main Aug 21, 2024
5 checks passed
@jryu01 jryu01 deleted the 4452-large-chart branch August 21, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK]: Investigate showing (popping up) larger version of vegalite chart
3 participants