Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup utils and experiments #4531

Merged
merged 13 commits into from
Aug 22, 2024
Merged

Cleanup utils and experiments #4531

merged 13 commits into from
Aug 22, 2024

Conversation

mwdchang
Copy link
Member

@mwdchang mwdchang commented Aug 22, 2024 •
edited
Loading

Summary

Another round of clean up

  • Remove unused theia experiment and loss function rendering
  • Move workflow-localstorage functions to workflow-service
  • Remove unused petrinet matrix service

@mwdchang mwdchang marked this pull request as ready for review August 22, 2024 19:14
Tom-Szendrey
Tom-Szendrey approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@Tom-Szendrey Tom-Szendrey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dan!!
Without all of these cleanup PRs I am scared to think what our codebase would look like knowing what it does now

@mwdchang mwdchang merged commit 17612f1 into main Aug 22, 2024
5 checks passed
@mwdchang mwdchang deleted the cleanup-utils-and-experiments branch August 22, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asylves1 asylves1 asylves1 approved these changes

@Tom-Szendrey Tom-Szendrey Tom-Szendrey approved these changes

@shawnyama shawnyama Awaiting requested review from shawnyama shawnyama is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mwdchang @Tom-Szendrey @asylves1