Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(model-diagram): add spinner #4533

Merged
merged 5 commits into from
Aug 22, 2024
Merged

style(model-diagram): add spinner #4533

merged 5 commits into from
Aug 22, 2024

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Aug 22, 2024 •
edited
Loading

Description

  • show spinner while model diagram is loading
  • removed quite a bit of useless html tags
Screen.Recording.2024-08-22.at.10.24.36.AM.mov

@shawnyama shawnyama marked this pull request as ready for review August 22, 2024 14:26
@shawnyama shawnyama changed the title style(model-diagram): clean up and add spinner style(model-diagram): add spinner Aug 22, 2024
mwdchang
mwdchang approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@mwdchang mwdchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@shawnyama shawnyama merged commit 00245f1 into main Aug 22, 2024
5 checks passed
@shawnyama shawnyama deleted the model-diagram-spinner branch August 22, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asylves1 asylves1 asylves1 approved these changes

@mwdchang mwdchang mwdchang approved these changes

@blanchco blanchco Awaiting requested review from blanchco blanchco is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shawnyama @mwdchang @asylves1