Optimize constraint - adding observables #4564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
2 tasks
Tom-Szendrey
requested review from
YohannParis,
mwdchang,
jryu01,
shawnyama,
blanchco and
asylves1
as code owners
…S/4528-add-observables-to-optimize-constraint
…S/4528-add-observables-to-optimize-constraint
mwdchang
reviewed
Sep 3, 2024
...nt/hmi-client/src/components/workflow/ops/optimize-ciemss/tera-optimize-ciemss-drilldown.vue
Show resolved
Hide resolved
mwdchang
approved these changes
Sep 3, 2024
|
merging cause we already merged the pyciemss-service couterpart |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
-Add observables as an option for optimize constraints.
-appending
_stateand_observablein hmi-client as it readily has the model accessible while we are creating these dropdown options anyways. This seems like a better spot than pyciemss-service where we would need to do moreRelated + required:
DARPA-ASKEM/pyciemss-service#114
Testing
While running pyciemss-service branch locally:
-running optimize drilldown with a state and ensure that it still runs + the output setting correctly gets defaulted
-running optimize drilldown with an observable, ensure it runs correctly + the output setting correctly gets defaulted.