Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dataset column information redesign #4582

Merged
merged 60 commits into from
Sep 9, 2024
Merged

dataset column information redesign #4582

merged 60 commits into from
Sep 9, 2024

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Aug 26, 2024 •
edited
Loading

Description

  • Enriching columns occurs reactively
  • Column information can now be edited and saved similarly to the model parts
  • I am only showing one concept now even though an array of them are generated after enrichment, designs should be updated
  • I am not using that enrichDataset() in the dataset util - doesn't seem to do anything helpful now
Screen.Recording.2024-08-29.at.8.48.29.PM.mov

Testing

  • Add a new dataset
  • Enrich it
  • Make some edits and click the save button
  • See if its saved

@shawnyama shawnyama linked an issue Aug 26, 2024 that may be closed by this pull request
[FEAT]: Dataset enrichment flow and update to page layout #4512
Closed
Base automatically changed from dataset-enrich-update to main August 27, 2024 18:22
@shawnyama shawnyama linked an issue Aug 27, 2024 that may be closed by this pull request
[BUG]: dataset enrichment without a document fails #3854
Closed
@shawnyama shawnyama changed the title data column comp dataset column information redesign Aug 27, 2024
@Tom-Szendrey
Copy link
Contributor

Hitting reset does not correctly clear the concept

  1. start with a dataset
  2. add a new concept
  3. hit reset

image

@Tom-Szendrey
Copy link
Contributor

unable to update units
When i click off this "days" is reset to empty

image

@shawnyama shawnyama merged commit 91429c9 into main Sep 9, 2024
5 checks passed
@shawnyama shawnyama deleted the data-column-info branch September 9, 2024 19:29
jryu01 pushed a commit that referenced this pull request Sep 10, 2024
@shawnyama @jryu01
dataset column information redesign (#4582)
e819474
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tom-Szendrey Tom-Szendrey Tom-Szendrey approved these changes

@YohannParis YohannParis YohannParis approved these changes

@mwdchang mwdchang Awaiting requested review from mwdchang mwdchang is a code owner

@jryu01 jryu01 Awaiting requested review from jryu01 jryu01 is a code owner

@blanchco blanchco Awaiting requested review from blanchco blanchco is a code owner

@asylves1 asylves1 Awaiting requested review from asylves1 asylves1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT]: Dataset enrichment flow and update to page layout [BUG]: dataset enrichment without a document fails
3 participants
@shawnyama @Tom-Szendrey @YohannParis