Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent setting empty expression, clean up expression parsing #4637

Merged
merged 1 commit into from
Sep 3, 2024
Merged

prevent setting empty expression, clean up expression parsing #4637

merged 1 commit into from
Sep 3, 2024

Conversation

mwdchang
Copy link
Member

Summary

  • Prevent setting expression or expression_mathml to empty as it cause problems later down the road
  • Clean up outdated expression parsing

@mwdchang mwdchang marked this pull request as ready for review August 30, 2024 16:04
Tom-Szendrey
Tom-Szendrey approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@Tom-Szendrey Tom-Szendrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did not test - looks good

jryu01
jryu01 approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@jryu01 jryu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mwdchang mwdchang merged commit 2d9d38b into main Sep 3, 2024
5 checks passed
@mwdchang mwdchang deleted the mathml-sanity-checks branch September 3, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tom-Szendrey Tom-Szendrey Tom-Szendrey approved these changes

@jryu01 jryu01 jryu01 approved these changes

@YohannParis YohannParis YohannParis approved these changes

@shawnyama shawnyama Awaiting requested review from shawnyama shawnyama is a code owner

@blanchco blanchco Awaiting requested review from blanchco blanchco is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mwdchang @YohannParis @jryu01 @Tom-Szendrey