Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jamie simulate page design polish #4682

Merged
merged 19 commits into from
Sep 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
2c12ad2
moved simulation wizard form into a collapsable side panel
jamiewaese-uncharted Sep 4, 2024
a491d7b
added empty state image to empty charts
jamiewaese-uncharted Sep 4, 2024
0f2441c
begin with settings sidebar open, empty state image for blank charts …
jamiewaese-uncharted Sep 5, 2024
c096a92
added empty state to page
jamiewaese-uncharted Sep 5, 2024
a670893
added empty state image to nodes
jamiewaese-uncharted Sep 5, 2024
d0c5c69
added padding betwen charts and at bottom of page
jamiewaese-uncharted Sep 5, 2024
d219b13
added padding between tabs and notes
jamiewaese-uncharted Sep 5, 2024
a6f0e28
decreased size of tabs
jamiewaese-uncharted Sep 5, 2024
1fbc80b
finesse annotation position, make pencil secondary color
jamiewaese-uncharted Sep 5, 2024
407453a
made notebook 50% width
jamiewaese-uncharted Sep 5, 2024
6138637
remove padding between charts in node
jamiewaese-uncharted Sep 5, 2024
c997340
Merge branch 'main' into jamie-simulate-page-design-polish
jamiewaese-uncharted Sep 5, 2024
a243972
kebab-case the classname
YohannParis Sep 6, 2024
46e25e0
Merge branch 'main' into jamie-simulate-page-design-polish
jamiewaese-uncharted Sep 6, 2024
c0dfee7
Merge remote-tracking branch 'origin/main' into jamie-simulate-page-d…
mwdchang Sep 6, 2024
61b5139
Remove comments
YohannParis Sep 6, 2024
316bc0d
clean up
mwdchang Sep 6, 2024
724fe5b
Merge branch 'jamie-simulate-page-design-polish' of github.com:DARPA-…
mwdchang Sep 6, 2024
17b7daa
Merge remote-tracking branch 'origin/main' into jamie-simulate-page-d…
mwdchang Sep 6, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ header .title {
header .tabs-row {
justify-content: space-between;
align-items: end;
gap: var(--gap-1);
gap: var(--gap-4);
}

header .tabs-row:deep(.p-tabview .p-tabview-panels) {
Expand All @@ -98,12 +98,15 @@ a {
:deep(.p-tabview .p-tabview-nav li .p-tabview-nav-link:focus) {
background-color: var(--surface-section);
}
:deep(.p-tabview .p-tabview-nav li .p-tabview-nav-link) {
padding: var(--gap-3) var(--gap-6);
}

.actions {
display: flex;
justify-content: flex-end;
gap: var(--gap-small);
padding-bottom: var(--gap-small);
padding-bottom: var(--gap-1);
flex: 1;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
</div>
</template>
<div v-else-if="!isEmpty(annotation)" class="annotation">
<p @click="isEditing = true">{{ annotation }}<span class="pi pi-pencil ml-2 text-xs" /></p>
<p @click="isEditing = true">{{ annotation }}<span class="pi pi-pencil ml-2 text-xs edit-button" /></p>
</div>
</section>
<Button
Expand Down Expand Up @@ -81,6 +81,7 @@ watch(
section {
display: flex;
flex: 1;

&:empty {
display: none;
}
Expand Down Expand Up @@ -114,6 +115,11 @@ section {
}
}

.edit-button {
color: var(--text-color-secondary);
cursor: pointer;
}

/* In drilldown */
&:not(.in-node) {
padding-bottom: var(--gap-small);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
</div>
</template>
<div v-else-if="isLoading === false" class="summary">
<p else @click="isEditing = true">{{ summaryText }}<span class="pi pi-pencil ml-2 text-xs" /></p>
<p else @click="isEditing = true">{{ summaryText }}<span class="pi pi-pencil ml-2 text-xs edit-button" /></p>
</div>
<div v-else-if="isLoading" class="summary">
<img src="@assets/svg/icons/magic.svg" alt="Magic icon" />
Expand Down Expand Up @@ -171,5 +171,10 @@ section {
&.is-editing {
padding: 0;
}

.edit-button {
color: var(--text-color-secondary);
cursor: pointer;
}
}
</style>
Loading
Loading