Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jamie dataset design tweaks #4694

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Jamie dataset design tweaks #4694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cadd3b5
misc beautification of the Dataset resource
jamiewaese-uncharted Sep 5, 2024
a349224
adjuste nav min-width to prevent wiggle when you scroll
jamiewaese-uncharted Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/client/hmi-client/src/components/asset/tera-asset.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ nav {
}

.nav-item {
min-width: 9rem;
min-width: 9.5rem;
}
header {
display: flex;
Expand All @@ -275,7 +275,7 @@ header {
background-color: var(--surface-0);
backdrop-filter: blur(6px);
overflow: hidden;
z-index: 1;
z-index: 3;
box-shadow: 0 0 0 0 rgba(0, 0, 0, 0);
transition: box-shadow 0.3s;
}
Expand Down
4 changes: 2 additions & 2 deletions packages/client/hmi-client/src/components/dataset/tera-dataset-datatable.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<!-- Toggle histograms & column summary charts -->
<div class="datatable-toolbar">
<span class="datatable-toolbar-item">
{{ rawContent.headers.length || 'No' }} columns | {{ rawContent.csv.length || 'No' }} rows
{{ rawContent.headers.length || 'No' }} columns | {{ rawContent.csv.length - 1 || 'No' }} rows
mwdchang marked this conversation as resolved.
Show resolved Hide resolved
</span>
<span class="datatable-toolbar-item" style="margin-left: auto">
Show column summaries<InputSwitch v-model="showSummaries" />
Expand Down Expand Up @@ -238,7 +238,7 @@ watch(
display: flex;
flex-direction: row;
gap: var(--gap);
padding-bottom: var(--gap);
padding-bottom: var(--gap-2);
}
.datatable-toolbar-item {
display: flex;
Expand Down
1 change: 1 addition & 0 deletions packages/client/hmi-client/src/components/dataset/tera-dataset-overview-table.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ watch(

.p-datatable:deep(.p-datatable-thead > tr > th) {
background-color: var(--surface-50);
padding-left: var(--gap);
}

.concept,
Expand Down
15 changes: 12 additions & 3 deletions packages/client/hmi-client/src/components/dataset/tera-dataset.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,13 @@
</div>
</template>
<section>
<div class="m-3">
<div class="pl-4 ml-3 pt-1 pb-3">
<p>
<span class="font-bold inline-block w-10rem">Dataset Id</span>
<span class="font-semibold inline-block w-10rem">Dataset ID</span>
<code class="inline">{{ datasetInfo.id }}</code>
</p>
<p>
<span class="font-bold inline-block w-10rem">Dataset Filenames</span>
<span class="font-semibold inline-block w-10rem">Dataset filenames</span>
{{ datasetInfo.fileNames }}
</p>
</div>
Expand All @@ -69,6 +69,7 @@
v-if="dataset"
:dataset="dataset"
@update-dataset="(dataset: Dataset) => updateAndFetchDataset(dataset)"
class="column-information-table"
/>
</AccordionTab>
<template v-else-if="dataset?.metadata">
Expand Down Expand Up @@ -368,6 +369,9 @@ watch(
</script>

<style scoped>
.column-information-table {
border: 1px solid var(--surface-border-light);
}
.btn-group {
display: flex;
align-items: center;
Expand Down Expand Up @@ -396,4 +400,9 @@ watch(
.col {
flex: 1;
}

/* Add gaps beneath open accordions */
:deep(.p-accordion-content) {
padding-bottom: var(--gap-6) !important;
}
</style>
5 changes: 3 additions & 2 deletions packages/client/hmi-client/src/components/widgets/tera-asset-enrichment.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<template>
<Button
label="Enrich metadata with AI assistant"
icon="pi pi-sparkles"
:loading="isLoading"
severity="secondary"
outlined
Expand All @@ -15,7 +16,7 @@
without additional context.
</p>
<ul>
<li v-for="document in documents" :key="document.id">
<li v-for="document in documents" :key="document.id" :class="document.id ? '' : 'mb-3'">
<RadioButton inputId="document.id" name="document.id" v-model="selectedResourceId" :value="document.id" />
<label :for="document.id">{{ document.name }}</label>
</li>
Expand All @@ -30,7 +31,7 @@
<Checkbox v-model="overwriteContent" inputId="overwriteContent" binary />
<div class="ml-3">
<label for="overwriteContent">Overwrite existing content</label>
<p class="text-subdued">If unselected, new content will be appeded</p>
<p class="text-subdued">If unselected, new content will be appended</p>
</div>
</div>
</template>
Expand Down
Loading