-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4732 feat cleanup the validate configuration modal #4762
Merged
shawnyama
merged 12 commits into
main
from
4732-feat-cleanup-the-validate-configuration-modal
Sep 12, 2024
Merged
4732 feat cleanup the validate configuration modal #4762
shawnyama
merged 12 commits into
main
from
4732-feat-cleanup-the-validate-configuration-modal
Sep 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brittanykondo
requested review from
YohannParis,
mwdchang,
jryu01,
Tom-Szendrey,
shawnyama,
blanchco,
asylves1 and
dgauldie
as code owners
September 12, 2024 16:20
brittanykondo
removed request for
mwdchang,
jryu01,
dgauldie,
Tom-Szendrey and
asylves1
September 12, 2024 16:20
shawnyama
reviewed
Sep 12, 2024
packages/client/hmi-client/src/components/workflow/ops/funman/tera-funman.vue
Show resolved
Hide resolved
shawnyama
approved these changes
Sep 12, 2024
blanchco
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine, although i do see that transform-dataset.md change is still happening 👍
shawnyama
deleted the
4732-feat-cleanup-the-validate-configuration-modal
branch
September 12, 2024 22:24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #4732