Model to latex with mira task #4831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tom-Szendrey
changed the title
…S/4090-task-replace-model-to-equations-code
…S/4090-task-replace-model-to-equations-code
Tom-Szendrey
requested review from
dgauldie,
dvince2,
YohannParis,
mwdchang,
jryu01,
shawnyama,
blanchco and
asylves1
as code owners
Merged
mwdchang
reviewed
Sep 17, 2024
YohannParis
approved these changes
Sep 17, 2024
dvince2
approved these changes
Sep 18, 2024
Thanks Yohann Co-authored-by: Yohann Paris <github@yohannparis.com>
mwdchang
reviewed
Sep 18, 2024
…S/4090-task-replace-model-to-equations-code
Tom-Szendrey
deleted the
TS/4090-task-replace-model-to-equations-code
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replacing sciml's
model-to-latexwith a mira task runner job.\operatornamerather than\mathrmI dont think this is an issue but please let me knowamr-to-mmt's test. AKA can the task be created.If we want more in depth testing please let me know either here or in the
askem-serverchannelFollow up:
Next PR will include the remaining removal of sciml. Just trying to limit the scope of this PR for readability.
Testing:
Go to a model page via project side panel, or model's drilldown in workflow and see equations:
Go to a broken model page and see that it correctly errors out on the task runner rather than waiting for a timeout (no pic of logs thats kindve silly?)
Here is a sample broken model where I have changed the expression to be a bit nonsense for
t0This will fail having a diagram as well as equationsSIR with failed equations.json