-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not update if there is a save pending #4842
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwdchang
requested review from
YohannParis,
jryu01,
Tom-Szendrey,
shawnyama,
blanchco and
asylves1
as code owners
September 23, 2024 22:05
YohannParis
approved these changes
Sep 24, 2024
packages/client/hmi-client/src/components/workflow/tera-workflow.vue
Outdated
Show resolved
Hide resolved
shawnyama
approved these changes
Sep 24, 2024
Tom-Szendrey
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This attempts to solve another round synchronization issue - the suspected culprits are the debouncers we are using for both saving-to-db and update-from-db going out of sync with each other. The primary reason for debouncers here is because we cannot send in a stream of updates across REST API without jamming-up every one else, so to resolve around that we introduce a couple of heuristics below.
To illustrate the potential sync problem:
Heuristic 1: Do not update if there is a save action pending
Heuristic 2: Do not update if we are dragging
In both cases, we acknowledge there is an update by incrementing the version number, but skip over the fields. The idea is that, for
The assumption is that only a single user works on an operator at a time.
Relates to
Testing
This should remedy strange jerkiness/flickers, as well as weird connection states between operator ports.